feat: improve e2e tests API + feeHistory test #12058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
fgimenez,
emhane and
gakonst
as code owners
mattsse
approved these changes
Oct 25, 2024
Comment on lines
+41
to
+42
| let (mut nodes, _tasks, wallet) = | ||
| setup_engine::<EthereumNode>(1, chain_spec.clone(), false, eth_payload_attributes).await?; |
There was a problem hiding this comment.
I just realized that returning the TaskManager here is kinda redundant:
reth/crates/e2e-test-utils/src/lib.rs
Line 133 in 5241586
and we can remove this from the response
Comment on lines
+41
to
+42
| let (mut nodes, _tasks, wallet) = | ||
| setup_engine::<EthereumNode>(1, chain_spec.clone(), false, eth_payload_attributes).await?; |
There was a problem hiding this comment.
also, should we wrap this into a helper type
reth/crates/e2e-test-utils/src/lib.rs
Line 113 in 5241586
I assume eventually we could use some utils that need to operate on all nodes for example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #12003
Simplifies e2e tests API by requiring payload building fn to be passed during node setup and by removing
versioned_hashesargument from payload building functions as it can be fetched fromBuiltPayloadAlso added a test for
feeHistoryendpoint