Apply beacon system call to trace_block #12030
Open
+33
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevencartavia
requested review from
mattsse,
Rjected and
emhane
as code owners
mattsse
requested changes
Oct 25, 2024
crates/rpc/rpc/src/debug.rs
Outdated
Comment on lines
107
to
114
| // Retrieve the block from the block ID | ||
| let block = match self.eth_api().block_with_senders(at).await? { | ||
| None => return Err(EthApiError::HeaderNotFound(at).into()), | ||
| Some(block) => block, | ||
| }; | ||
|
|
||
| // Extract the parent beacon block root from the block | ||
| let parent_beacon_block_root = block.parent_beacon_block_root; |
There was a problem hiding this comment.
I believe this shouldn't be required here, because we always fetch the block before we call this function.
so we can likely solve this by adding the parent beacon block root as another argument to this function
mattsse
added
C-bug
|
updated with the changes from #12095 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12021