refactor: use op-alloy deposit signature #12016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caglaryucekaya
requested review from
Rjected,
mattsse,
fgimenez,
emhane and
gakonst
as code owners
caglaryucekaya
force-pushed
the
use-optimism-deposit-signature
branch
from
9759255
to
2b490cd
Compare
onbjerg
requested changes
Oct 24, 2024
| @@ -82,7 +82,7 @@ pub fn legacy_parity(signature: &Signature, chain_id: Option<u64>) -> Parity { | |||
| // transactions with an empty signature | |||
| // | |||
| // NOTE: this is very hacky and only relevant for op-mainnet pre bedrock | |||
| if *signature == optimism_deposit_tx_signature() { | |||
| if *signature == TxDeposit::signature() { | |||
There was a problem hiding this comment.
nit: we want to move away from the cfg imports, so let's do
Suggested change
| if *signature == TxDeposit::signature() { | |
| if *signature == op_alloy_consensus::TxDeposit::signature() { |
and remove the top level cfg import
onbjerg
added
C-debt
onbjerg
approved these changes
Oct 24, 2024
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11781