-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use op-alloy deposit signature #12016
refactor: use op-alloy deposit signature #12016
Conversation
9759255
to
2b490cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smol nit
@@ -82,7 +82,7 @@ pub fn legacy_parity(signature: &Signature, chain_id: Option<u64>) -> Parity { | |||
// transactions with an empty signature | |||
// | |||
// NOTE: this is very hacky and only relevant for op-mainnet pre bedrock | |||
if *signature == optimism_deposit_tx_signature() { | |||
if *signature == TxDeposit::signature() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we want to move away from the cfg imports, so let's do
if *signature == TxDeposit::signature() { | |
if *signature == op_alloy_consensus::TxDeposit::signature() { |
and remove the top level cfg import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Closes #11781