chore: remove some clones #12008
Merged
chore: remove some clones #12008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hai-rise
requested review from
mattsse,
Rjected,
fgimenez,
emhane and
rakita
as code owners
mattsse
approved these changes
Oct 23, 2024
| @@ -156,7 +150,7 @@ where | |||
| /// a result indicating success with the payload or an error in case of failure. | |||
| #[inline] | |||
| pub(crate) fn optimism_payload<EvmConfig, Pool, Client>( | |||
| evm_config: EvmConfig, | |||
| evm_config: &EvmConfig, | |||
There was a problem hiding this comment.
this is not strictly required
Suggested change
| evm_config: &EvmConfig, | |
| evm_config: EvmConfig, |
There was a problem hiding this comment.
Hmm, we need this to pass &self.evm_config in from try_build and build_empty_payload instead of cloning anew?
There was a problem hiding this comment.
EvmConfig is auto_impl for & so this shouldn't be required by we can also do &
There was a problem hiding this comment.
Wouldn't work 😅.
error[E0521]: borrowed data escapes outside of method
--> crates/optimism/payload/src/builder.rs:108:9
|
104 | &self,
| -----
| |
| `self` is a reference that is only valid in the method body
| let's call the lifetime of this reference `'1`
...
108 | optimism_payload(&self.evm_config, args, cfg_env, block_env, self.compute_pending_block)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| `self` escapes the method body here
| argument requires that `'1` must outlive `'static`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.