feat: Add more complex E2E test #12005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
reviewed
Oct 23, 2024
Comment on lines
+64
to
+71
| let requests = payload | ||
| .executed_block() | ||
| .unwrap() | ||
| .execution_outcome() | ||
| .requests | ||
| .first() | ||
| .unwrap() | ||
| .clone(); |
There was a problem hiding this comment.
we should likely track some improvement on this, it's not nice and i think we're doing it in some other place too
| let signer = signers.choose(&mut rng).unwrap(); | ||
| let auth = Authorization { | ||
| chain_id: provider.get_chain_id().await?, | ||
| address: *call_destinations.choose(&mut rng).unwrap(), |
There was a problem hiding this comment.
this will never actually delegate as it will try to delegate to an empty account
There was a problem hiding this comment.
I think for this test this doesn't really matter
onbjerg
added
C-test
mattsse
approved these changes
Oct 24, 2024
| let signer = signers.choose(&mut rng).unwrap(); | ||
| let auth = Authorization { | ||
| chain_id: provider.get_chain_id().await?, | ||
| address: *call_destinations.choose(&mut rng).unwrap(), |
There was a problem hiding this comment.
I think for this test this doesn't really matter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #12003
e2e_test_utils::setup_enginehelper which allows to setup multiple nodes with new engine similarly toe2e_test_utils::setuprequestsfield