-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add more complex E2E test #12005
Conversation
let requests = payload | ||
.executed_block() | ||
.unwrap() | ||
.execution_outcome() | ||
.requests | ||
.first() | ||
.unwrap() | ||
.clone(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should likely track some improvement on this, it's not nice and i think we're doing it in some other place too
let signer = signers.choose(&mut rng).unwrap(); | ||
let auth = Authorization { | ||
chain_id: provider.get_chain_id().await?, | ||
address: *call_destinations.choose(&mut rng).unwrap(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will never actually delegate as it will try to delegate to an empty account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for this test this doesn't really matter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, let's use this for incremental improvements
let signer = signers.choose(&mut rng).unwrap(); | ||
let auth = Authorization { | ||
chain_id: provider.get_chain_id().await?, | ||
address: *call_destinations.choose(&mut rng).unwrap(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for this test this doesn't really matter
ref #12003
e2e_test_utils::setup_engine
helper which allows to setup multiple nodes with new engine similarly toe2e_test_utils::setup
requests
field