Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase max proof window #12001

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

meyer9
Copy link
Contributor

@meyer9 meyer9 commented Oct 23, 2024

Increases the max configurable proof window to 1 month. @0x00101010 mentioned this change had already been discussed.

@onbjerg
Copy link
Member

onbjerg commented Oct 23, 2024

What is the motivation here? Noting that increasing the proof window means you can send more and more expensive eth_getProof requests to Reth, which might require really beefy nodes depending on what chain you are running

@meyer9
Copy link
Contributor Author

meyer9 commented Oct 23, 2024

What is the motivation here? Noting that increasing the proof window means you can send more and more expensive eth_getProof requests to Reth, which might require really beefy nodes depending on what chain you are running

We're testing these requests currently and we've found it takes a somewhat reasonable time for an account proof from 300k blocks ago, which is the current limit. We'd like to test a longer window.

This doesn't increase the proof window, but does increase the configurable proof window (still defaults to 0).

The underlying motivation is to get reth working with Optimism as an L2 EL client (currently requires debug_dbGet, but is being refactored to use debug_executionWitness and eth_getProof).

@0x00101010 can add some more context if needed I think

@0x00101010
Copy link
Contributor

What is the motivation here? Noting that increasing the proof window means you can send more and more expensive eth_getProof requests to Reth, which might require really beefy nodes depending on what chain you are running

@onbjerg This is to support fault proof programs on op-stack, where we need to be able to call eth_getProof for blocks that are ~month old in extreme cases.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't limit this on a per network basis yet, so this seems fine and since this is opt-in we can do this we need the some reference data for larger ranges anyway

@mattsse mattsse added this pull request to the merge queue Oct 23, 2024
Merged via the queue into paradigmxyz:main with commit 57a21fc Oct 23, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants