Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check failed find nodes requests before sending new ones #11997

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 23, 2024

closes #11992

this adds new checks before we send a new FindNode request.
if previous FindNode requests failed we try to establish a new endpoint proof first by pinging the node first before continuing with the lookup.

this will renew the endpoint proof on the other peer's end.

@mattsse mattsse requested a review from onbjerg October 23, 2024 11:12
@mattsse mattsse added the A-networking Related to networking in general label Oct 23, 2024
@github-actions github-actions bot added A-discv4 Related to discv4 discovery C-enhancement New feature or request labels Oct 23, 2024
@onbjerg onbjerg added C-bug An unexpected or incorrect behavior and removed C-enhancement New feature or request labels Oct 23, 2024
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onbjerg onbjerg force-pushed the matt/check-pending-node-failures branch from d05ec97 to 5151182 Compare October 23, 2024 13:16
@onbjerg onbjerg added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 55d98bb Oct 23, 2024
38 checks passed
@onbjerg onbjerg deleted the matt/check-pending-node-failures branch October 23, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-discv4 Related to discv4 discovery A-networking Related to networking in general C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

discv4: Resend ping after subsequent findNode failures
2 participants