Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add op-reth test-vectors compact --write|--read to CI #11994

Merged
merged 1 commit into from
Oct 24, 2024
Merged

feat: add op-reth test-vectors compact --write|--read to CI #11994

merged 1 commit into from
Oct 24, 2024

Conversation

joshieDo
Copy link
Collaborator

on top of #11954

  • adds test-vectors to op-reth
  • adds TxDeposit to tested types
  • adds op-reth to compact-codecs.yml

@joshieDo joshieDo added A-op-reth Related to Optimism and op-reth A-ci Related to github workflows or other build and lint tools labels Oct 23, 2024
@joshieDo joshieDo force-pushed the joshie/top branch 2 times, most recently from 58b0050 to 34efa74 Compare October 23, 2024 12:51
@joshieDo joshieDo force-pushed the joshie/tcomp branch 2 times, most recently from 39d90be to 3ad8aa7 Compare October 23, 2024 13:55
@joshieDo joshieDo force-pushed the joshie/top branch 2 times, most recently from 29310ec to 78995c2 Compare October 23, 2024 14:08
@joshieDo joshieDo mentioned this pull request Oct 23, 2024
Merged
@joshieDo joshieDo force-pushed the joshie/top branch 2 times, most recently from 038abb6 to 7dfee89 Compare October 23, 2024 14:13
@joshieDo joshieDo force-pushed the joshie/tcomp branch 2 times, most recently from 83e7605 to 04ce3d4 Compare October 23, 2024 14:15
@joshieDo joshieDo force-pushed the joshie/tcomp branch 2 times, most recently from 7e128b1 to 28c5e3f Compare October 23, 2024 14:37
@joshieDo joshieDo force-pushed the joshie/top branch 2 times, most recently from e7b2098 to 7cc6b26 Compare October 23, 2024 14:47
@joshieDo joshieDo marked this pull request as draft October 23, 2024 15:44
@joshieDo joshieDo force-pushed the joshie/tcomp branch 2 times, most recently from c482a9d to c6786c8 Compare October 23, 2024 15:46
@mattsse mattsse mentioned this pull request Oct 24, 2024
Closed
@joshieDo joshieDo force-pushed the joshie/top branch 2 times, most recently from cfde53b to f0f7913 Compare October 24, 2024 09:38
@joshieDo joshieDo marked this pull request as ready for review October 24, 2024 09:40
mattsse
mattsse approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse merged commit 4433c06 into joshie/tcomp Oct 24, 2024
20 of 34 checks passed
@mattsse mattsse deleted the joshie/top branch October 24, 2024 11:26
@tcoratger tcoratger mentioned this pull request Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg

@gakonst gakonst Awaiting requested review from gakonst

@DaniPopes DaniPopes Awaiting requested review from DaniPopes

@Rjected Rjected Awaiting requested review from Rjected

@fgimenez fgimenez Awaiting requested review from fgimenez

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
A-ci Related to github workflows or other build and lint tools A-op-reth Related to Optimism and op-reth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshieDo @mattsse