chore(cli): engine cli options conflict with legacy #11993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
added
C-debt
mattsse
previously requested changes
Oct 23, 2024
Comment on lines
+36
to
+40
| #[arg(long = "engine.persistence-threshold", conflicts_with = "legacy", default_value_t = DEFAULT_PERSISTENCE_THRESHOLD)] | ||
| pub persistence_threshold: u64, | ||
|
|
||
| /// Configure the target number of blocks to keep in memory. | ||
| #[arg(long = "engine.memory-block-buffer-target", requires = "experimental", default_value_t = DEFAULT_MEMORY_BLOCK_BUFFER_TARGET)] | ||
| #[arg(long = "engine.memory-block-buffer-target", conflicts_with = "legacy", default_value_t = DEFAULT_MEMORY_BLOCK_BUFFER_TARGET)] |
There was a problem hiding this comment.
I'm not convinced this works as expected because the name of legacy is engine.legacy
There was a problem hiding this comment.
that's just how clap vars are referenced 🤷♂️, feel free to try it yourself. a test here would be pedantic
rkrasiuk
force-pushed
the
rkrasiuk/engine-cli-conflicts-legacy
branch
from
eaeca5f
to
109a6d3
Compare
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change engine CLI options to no longer require
--engine.experimental(as it is default now) and conflict with--engine.legacy.