Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ping oldest more often #11988

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix: ping oldest more often #11988

merged 1 commit into from
Oct 22, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 22, 2024

fixes a flaw in the re-ping logic

first, the re-ping interval was too high because this should check for expired nodes more often.

we also can't use the ENDPOINT_PROOF_EXPIRATION is the threshold because by the time this is reached the peer has already lost its bond, this sets it to every 12h now

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@onbjerg onbjerg added C-bug An unexpected or incorrect behavior A-discv4 Related to discv4 discovery labels Oct 22, 2024
@mattsse mattsse added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 6e51762 Oct 22, 2024
39 checks passed
@mattsse mattsse deleted the matt/ping-oldest-more-often branch October 22, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-discv4 Related to discv4 discovery C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants