opt: reduce allocs for parse_deposits_from_receipts
#11949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
force-pushed
the
prestwich/accumulate-requests
branch
from
0d37850
to
5ee55fd
Compare
mattsse
approved these changes
Oct 22, 2024
onbjerg
added
C-perf
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes allocations by preventing the creation of an intermediate
Bytesobject for each deposit request bytestring. Instead, they're accumulated into a single vec. This ensures at most 1 allocation per deposit request, while the previous version had 2Also removes some outdated docstrings and comments
According to etherscan, there is typically less than 1 of these per block, so this is a minor-but-easy optimization :)