feat: default impl for some BlockExecutionStrategy methods #11941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
requested review from
mattsse,
Rjected,
emhane and
rakita
as code owners
fgimenez
changed the title
mattsse
approved these changes
Oct 21, 2024
| @@ -209,18 +213,23 @@ pub trait BlockExecutionStrategy<DB> { | |||
| fn state_mut(&mut self) -> &mut State<DB>; | |||
|
|
|||
| /// Sets a hook to be called after each state change during execution. | |||
| fn with_state_hook(&mut self, hook: Option<Box<dyn OnStateHook>>); | |||
| fn with_state_hook(&mut self, _hook: Option<Box<dyn OnStateHook>>) {} | |||
There was a problem hiding this comment.
this a bit weird that we allow this if the hook can be ignored.
but I think for now this is okay.
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implemented methods are:
finish: full implementation taking advantage ofstate_mut.with_state_hook: empty, no state hook by default.validate_block_post_execution: empty, no validation on batch executor by default.