Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always accept transactions with current nonce #11931

Merged
merged 2 commits into from
Oct 21, 2024
Merged

fix: always accept transactions with current nonce #11931

merged 2 commits into from
Oct 21, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Oct 21, 2024

Closes #11922

Adds a check to ensure_valid which ensures we don't reject transactions which have on-chain nonce

@klkvr klkvr requested a review from mattsse as a code owner October 21, 2024 12:23
@github-actions github-actions bot added A-tx-pool Related to the transaction mempool C-bug An unexpected or incorrect behavior C-enhancement New feature or request labels Oct 21, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, can we add one test case for this:

insert nonce max slots nonce gapped txs
ensure further nonce gapped tx is rejected
ensure next nonce tx is accepted

@klkvr
Copy link
Collaborator Author

klkvr commented Oct 21, 2024

@mattsse I've modified existing test, lmk if a new one would be better

@klkvr klkvr requested a review from mattsse October 21, 2024 19:06
@mattsse mattsse added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit cc895e7 Oct 21, 2024
38 checks passed
@mattsse mattsse deleted the klkvr/11922 branch October 21, 2024 20:29
onbjerg pushed a commit to ithacaxyz/odyssey that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tx-pool Related to the transaction mempool C-bug An unexpected or incorrect behavior C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to replace sender's transactions if capacity reached
2 participants