feat: transaction trait #11877
feat: transaction trait #11877
Conversation
|
Hey @emhane ! Could you have a look at this one please? |
| /// Helper trait that unifies all behaviour required by transaction to support full node operations. | ||
| pub trait FullTransaction: Transaction + Compact {} | ||
|
|
||
| impl<T> FullTransaction for T where T: Transaction + Compact {} |
There was a problem hiding this comment.
revert this, we don't want to require Compact be a super trait for Transaction
| pub trait Transaction: | ||
| alloy_consensus::Transaction | ||
| #[allow(dead_code)] | ||
| /// Inner trait for a raw transaction. |
There was a problem hiding this comment.
| /// Inner trait for a raw transaction. | |
| /// Abstraction of a transaction. |
| @@ -1,28 +1,65 @@ | |||
| //! Transaction abstraction | |||
There was a problem hiding this comment.
leave this module docs here, remove them from lib.rs for this module
| /// Trait that defines methods of a raw transaction. | ||
| /// | ||
| /// Transaction types were introduced in [EIP-2718](https://eips.ethereum.org/EIPS/eip-2718). | ||
| #[cfg(feature = "arbitrary")] | ||
| pub trait FullTransaction<T>: Transaction<T> + Compact + for<'b> arbitrary::Arbitrary<'b> {} |
There was a problem hiding this comment.
when asked to revert, please also revert the code docs. one should always think, that the docs and the code are glued together and are inseparable.
| /// Trait that defines methods of a raw transaction. | |
| /// | |
| /// Transaction types were introduced in [EIP-2718](https://eips.ethereum.org/EIPS/eip-2718). | |
| #[cfg(feature = "arbitrary")] | |
| pub trait FullTransaction<T>: Transaction<T> + Compact + for<'b> arbitrary::Arbitrary<'b> {} | |
| /// Helper trait that unifies all behaviour required by transaction to support full node operations. | |
| #[cfg(feature = "arbitrary")] | |
| pub trait FullTransaction<T>: Transaction<T> + Compact + for<'b> arbitrary::Arbitrary<'b> {} |
| /// Trait that defines methods of a raw transaction. | ||
| /// | ||
| /// Transaction types were introduced in [EIP-2718](https://eips.ethereum.org/EIPS/eip-2718). |
There was a problem hiding this comment.
| /// Trait that defines methods of a raw transaction. | |
| /// | |
| /// Transaction types were introduced in [EIP-2718](https://eips.ethereum.org/EIPS/eip-2718). | |
| /// Helper trait that unifies all behaviour required by transaction to support full node operations. |
| + Serialize | ||
| + for<'de> Deserialize<'de> | ||
| + From<T> |
There was a problem hiding this comment.
| + From<T> |
we don't need this
| alloy_consensus::Transaction | ||
| #[allow(dead_code)] | ||
| /// Inner trait for a raw transaction. | ||
| pub trait Transaction<T>: |
There was a problem hiding this comment.
| pub trait Transaction<T>: | |
| pub trait Transaction: |
we don't this to have a generic, if anything, give it an associated type
|
|
||
| use alloy_rlp::Encodable; |
There was a problem hiding this comment.
| use alloy_rlp::Encodable; |
| + alloy_rlp::Encodable | ||
| + alloy_rlp::Decodable | ||
| + PartialEq | ||
| + Encodable |
There was a problem hiding this comment.
| + Encodable |
revert to
+ alloy_rlp::Encodable
+ alloy_rlp::Decodablewe like to have the longer path to know what encoding this is
There was a problem hiding this comment.
another idea for arbitrary feature, is to do smthg like this in order to use it as super trait independently of FullTransaction, as you initially thought, but without requiring impl of another trait TransactionInner on transaction types alloy-rs/core#766 (comment)
so for this case it would be
#[cfg(not(feature = "arbitrary"))]
trait MaybeArbitrary {}
#[cfg(feature = "arbitrary")]
trait MaybeArbitrary: for<'a> arbitrary::Arbitrary<'a> {}
pub trait Transaction: .. + MaybeArbitrary {
..
}but we can merge this pr as is and make that change in a follow up pr
That makes sense! |
Transaction trait has been partially implemented but it's missing a few trait bounds as well as the behavior of
reth_primitives::TransactionCloses #11533