Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use highest known nonce #11784

Merged
merged 1 commit into from
Oct 16, 2024
Merged

chore: use highest known nonce #11784

merged 1 commit into from
Oct 16, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 16, 2024

it's possible that this already tracks a higher nonce so we should use that instead.

@mattsse mattsse requested a review from onbjerg October 16, 2024 09:31
@mattsse mattsse added C-enhancement New feature or request A-tx-pool Related to the transaction mempool labels Oct 16, 2024
onbjerg
onbjerg approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we should likely rename on_chain though, it's a bit of a bad name imo

@onbjerg onbjerg added this pull request to the merge queue Oct 16, 2024
@mattsse
Copy link
Collaborator Author

mattsse commented Oct 16, 2024

open for suggestions

Merged via the queue into main with commit e454b24 Oct 16, 2024
40 checks passed
@onbjerg onbjerg deleted the matt/check-against-tracked-nonce branch October 16, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @onbjerg