Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut down on reth-primitives::TransactionSigned usage #13631

Closed
mattsse opened this issue Jan 3, 2025 · 9 comments
Closed

Cut down on reth-primitives::TransactionSigned usage #13631

mattsse opened this issue Jan 3, 2025 · 9 comments
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-blocked This cannot more forward until something else changes

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jan 3, 2025

Describe the feature

This type will be deprecated as soon as possible

pub struct TransactionSigned {

main blocker rn is that this type is still used excessively as default type, eg.

pub type Block<T = TransactionSigned> = alloy_consensus::Block<T>;

and in testing.

TODO

we need to gradually replace usage of this type with the non-problematic ethereum specific type:

pub struct TransactionSigned {

ideally on a crate by crate basis

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jan 3, 2025
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started A-sdk Related to reth's use as a library and removed S-needs-triage This issue needs to be labelled labels Jan 3, 2025
@hoank101
Copy link
Contributor

hoank101 commented Jan 3, 2025

hi i can do it

@mattsse
Copy link
Collaborator Author

mattsse commented Jan 3, 2025

@hoank101 this task is kinda cursed, so I recommed doing this is very small chunks

@bestselection18
Copy link

Can I take this issue?

@PoulavBhowmick03
Copy link

Gm gm! I would love to work on this! I have some experience in Rust and have contributed to projects like Starknet Foundry and dojo. This would be my first time contributing to Reth!

@V15HNUPM
Copy link

V15HNUPM commented Jan 6, 2025

Could I take on this issue?

@PedroRosalba
Copy link

Let me try this one!

@mattsse
Copy link
Collaborator Author

mattsse commented Jan 13, 2025

blocking this until after #13735

@mattsse mattsse added the S-blocked This cannot more forward until something else changes label Jan 13, 2025
@zachwood222
Copy link

May I take this issue on?

@mattsse
Copy link
Collaborator Author

mattsse commented Jan 17, 2025

marking this as closed now

@mattsse mattsse closed this as completed Jan 17, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started S-blocked This cannot more forward until something else changes
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants