-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut down on reth-primitives::TransactionSigned usage #13631
Comments
hi i can do it |
@hoank101 this task is kinda cursed, so I recommed doing this is very small chunks |
Can I take this issue? |
Gm gm! I would love to work on this! I have some experience in Rust and have contributed to projects like Starknet Foundry and dojo. This would be my first time contributing to Reth! |
Could I take on this issue? |
Let me try this one! |
blocking this until after #13735 |
May I take this issue on? |
marking this as closed now |
Describe the feature
This type will be deprecated as soon as possible
reth/crates/primitives/src/transaction/mod.rs
Line 786 in 82013f4
main blocker rn is that this type is still used excessively as default type, eg.
reth/crates/primitives/src/block.rs
Line 19 in 82013f4
and in testing.
TODO
we need to gradually replace usage of this type with the non-problematic ethereum specific type:
reth/crates/ethereum/primitives/src/transaction.rs
Line 260 in 82013f4
ideally on a crate by crate basis
Additional context
No response
The text was updated successfully, but these errors were encountered: