feature for window handling in freamless mode #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add/update conponents: Storage.qml : storage global data cross over all app sessions Resizer.qml : right-bottom icon for resizing window size ActionBar.qml : add window draging(pos) double-click(normal/fullscreen) the feature is enabled when ApplicationWindows.clientSideDecorations set be true
feature for window handling in freamless mode
|
@ibeliever isn't this managed in the plugin c++ code? |
|
@ricardomv Not really. Yes, we do use Qt's client-side window decorations. But what this is adding support for is combining the window decorations and the toolbar into one common toolbar. |
|
oh when i saw the resize code i thought it was for the window edge resize. |
| @@ -6,6 +6,7 @@ ApplicationWindow { | |||
| id: demo | |||
|
|
|||
| title: "Material for QtQuick Demo" | |||
| clientSideDecorations : true | |||
There was a problem hiding this comment.
i don't think this should be the default behavior and the indentation is wrong use 4 spaces instead of tabs
|
first, sorry for the HUGE delay of the padding works. now i have a problem about what is the best practice to pick up the work. i came up with two solutions :
what should i do? |
# Conflicts: # src/qmldir # src/window/ActionBar.qml # src/window/ApplicationWindow.qml should be always staying with the upstream !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add/update components:
Storage.qml : store global data cross over app sessions
Resizer.qml : right-bottom icon for resizing window size
ActionBar.qml : add window draging(pos) double-click(normal/fullscreen)
the feature is enabled when ApplicationWindows.clientSideDecorations set be true