Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fullscreen dialog #294

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

osechet
Copy link

@osechet osechet commented Sep 21, 2015

Hello!
I implemented the full-screen dialog (http://www.google.fr/design/spec/components/dialogs.html#dialogs-full-screen-dialogs) following the comments I made in the issue #287. I modified the demo to include the full-screen dialog in the " Compund Components" section.
I just had problems with the density management. My environment is not setup to build for Android so I could only test the dialog on a PC. But the pixel density returned by Qt for my monitor is surprising. So i'm using Units.multiplier until I get a better idea about that density issue.
I had to create a new OverlayLayer in ApplicationWindow in order to be able to open normal dialogs from the full-screen dialog..

@iBelieve iBelieve modified the milestone: Version 0.2 Dec 18, 2015
@iBelieve iBelieve modified the milestones: Version 0.2, Version 0.3 Jan 6, 2016
Merge from original repo
Update branch with latest modifications
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 526a98a on osechet:feature/fullscreen_dialog into ** on papyros:develop**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants