Allow for aliasing the different timer metrics #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These can be set as needed in the config file and use the existing settings as the defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These can be set as needed in the config file and use the existing settings as the defaults.
Up until this point we've been using a fork of statsd @paperlesspost that was forked VERY early on and went in a different direction for a while. We want to get back up to trunk, but without being able to alias these new timer metrics, we loose consistency between our current metrics and would have to either migrate a lot of files, or just start from scratch. This gives us (and probably other people) the best of both worlds, being able to use statsd but having our uppers called max's and etc.