Add support of animated stickers and emojis #429

yuraiz · 2023-01-17T15:16:30Z

animatons.webm

Features:

sticker loading preview (moved to Add vector path for stickers #470)
animated stickers
animated emojis
premium emojis are looped, but default arent
play animated emoji on click

melix99 · 2023-01-17T15:29:06Z

Looks like the first two commits need to be squashed?

yuraiz · 2023-01-17T15:33:01Z

Oops, looks like it's better to squash all commits

melix99 · 2023-01-17T15:34:24Z

Oops, looks like it's better to squash all commits

I mean, having 1 commit per feature/change is usually what I prefer and it makes reviewing PRs much easier.

yuraiz · 2023-01-17T15:36:14Z

Last commit also change sticker. And I don't sure how to separate them

melix99 · 2023-01-17T15:41:15Z

Last commit also change sticker. And I don't sure how to separate them

You need to use git rebase for that. I highly suggest learning that to make reviewers life much easier :)

yuraiz · 2023-01-17T16:24:03Z

I think features are separated ok now

src/session_manager.rs

melix99 · 2023-02-13T21:31:40Z

This PR does a lot of stuff and the way you organized the commits makes it hard to review (you do one thing in one and then change everything in the other). For what I can see this PR does the following:

Adds Tgs support to MessageSticker
Adds VectorPath to show a preview while loading stickers
Adds support to MessageAnimatedEmoji message type
Adds the "click reaction" to animated emojis
Some unrelated stuff (cargo update, .editorconfig)

This is great, but I think that this is too much for a single PR. I would be glad if you split it at least in 2 parts (with good organized commits too).

Since the title of the PR is "Add support of animated stickers and emojis", do you mind only leaving the TGS support for stickers and MessageAnimatedEmoji support here, please? I think the rest can go in a separate PR for now.

src/session/content/chat_action_bar.rs

src/session_manager.rs

data/resources/ui/content-message-sticker.blp

src/session/content/message_row/sticker.rs

src/strings.rs

src/session/content/message_row/sticker.rs

Cargo.toml

src/components/sticker.rs

melix99 · 2023-03-23T21:29:46Z

src/components/sticker.rs

+
+    #[derive(Default)]
+    pub struct Sticker {
+        pub(super) message_id: Cell<i64>,


Am I wrong or this property seems completely useless? Also, it doesn't make sense to have it anyway because if I understand correctly we're gonna use this widget outside of the messages as well (like for a sticker picker).

I want to check if widget isn't recycled after sticker is downloaded IIRC you have a similar check in MessageDocument

Ah k, yeah that check is important. The problem is that I don't like the fact that it's placed in the generic component. Maybe it's better having a sync variant to load the sticker and still do the check in MessageSticker?

melix99 · 2023-03-23T21:32:14Z

src/session/content/message_row/sticker.rs

+        match &sticker.full_type {
+            StickerFullType::CustomEmoji(data) if data.needs_repainting => {
+                self.add_css_class("needs-repainting")
            }
+            _ => self.remove_css_class("needs-repainting"),
        }


Mh, I don't really get what this css class is for.

Check one of those packs: Emoticon Emoji, Outline Emoji, Animal Emoji

Those emojis can be either black or white dependent on theme, currently I'm using css to recolor them

Screencast.from.2023-03-24.09-14-40.webm

src/components/sticker.rs

Don't trim emoji

yuraiz mentioned this pull request Jan 17, 2023

Add support of animated stickers #386

Closed

yuraiz force-pushed the animated-emojis branch from ca3b686 to 6f3e651 Compare January 17, 2023 15:36

yuraiz force-pushed the animated-emojis branch 4 times, most recently from c9de911 to 668435d Compare January 17, 2023 16:05

yuraiz force-pushed the animated-emojis branch 2 times, most recently from 595aa2f to 0b910fc Compare January 21, 2023 18:09

yuraiz commented Jan 21, 2023

View reviewed changes

src/session_manager.rs Outdated Show resolved Hide resolved

melix99 mentioned this pull request Feb 5, 2023

Tracking Issue: Message Support #450

Open

yuraiz force-pushed the animated-emojis branch 2 times, most recently from 2d3d01d to 4c4445c Compare February 6, 2023 09:38

yuraiz requested a review from melix99 February 6, 2023 09:58

yuraiz force-pushed the animated-emojis branch 6 times, most recently from 938b3a6 to edf97cd Compare February 13, 2023 08:31

yuraiz force-pushed the animated-emojis branch from bc79aae to 550b4e3 Compare February 13, 2023 10:51

yuraiz force-pushed the animated-emojis branch 2 times, most recently from e2cc14b to c11f6b0 Compare February 14, 2023 19:47

yuraiz force-pushed the animated-emojis branch from c11f6b0 to 29dce2e Compare March 13, 2023 08:53

yuraiz force-pushed the animated-emojis branch from 29dce2e to 48e8a94 Compare March 13, 2023 09:27

Newbytee reviewed Mar 13, 2023

View reviewed changes

src/session/content/chat_action_bar.rs Outdated Show resolved Hide resolved

src/session_manager.rs Show resolved Hide resolved

melix99 added this to the Telegrand 0.1 milestone Mar 22, 2023