Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information to Application output regarding what will be run on --commit #27

Open
funnell opened this issue Jan 11, 2023 · 1 comment

Comments

@funnell
Copy link
Collaborator

funnell commented Jan 11, 2023

  • isabl_cli version: 0.1.0

New feature

For example, when i ran an app without “--commit” and it give me this message:

RAN 150 | SKIPPED 100 | INVALID 0

Add --commit to proceed.

which I interpreted to mean that adding --commit will run only the 150 analyses listed as RAN, and skip all the 100 analyses listed as SKIPPED. Instead, adding --commit resulted in this output:

RAN 247 | SKIPPED 3 | INVALID 0

Which ended up running the 150 new analyses created from the initial invocation, plus 97 unprotected SUCCEEDED analyses, skipping 3 unprotected FAILED analyses.

My request is to change or add additional information to the app summary output to make it clearer for less experienced Isabl users to understand what is happening, and also what will happen on invocation with --commit

@funnell
Copy link
Collaborator Author

funnell commented Jan 11, 2023

Here I'll give a suggestion for updating the summary output, using the above scenario

first invocation without --commit:

STAGED 150 | SKIPPED 100 | INVALID 0

Add --commit to run 247 analyses:

150  STAGED
97   SUCCEEDED (Unprotected)

3 FAILED analyses will be skipped

Changing RAN->STAGED may be clearer about what work has been performed, and the additional summary at the end will clarify what will happen upon invoking with --commit

second invocation with --commit:

RAN 247 | SKIPPED 3 | INVALID 0

nothing has changed here

juanesarango pushed a commit that referenced this issue Jun 16, 2023
…mit (#27) (#53)

* update ran_by_user_test
* update app output on commit
* new updates commit description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant