Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure CI is checking formatting #54

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Ensure CI is checking formatting #54

merged 4 commits into from
Jan 4, 2024

Conversation

thejcannon
Copy link
Member

Fixes #52 by using --check on check-formatting script.

Then re-formats the repo.

@thejcannon thejcannon requested a review from huonw January 3, 2024 20:44
huonw
huonw approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I'm assuming you've at least done some spot checks that the display looks good locally?

@thejcannon
Copy link
Member Author

For the most part I was only ever checking the rendered files post-prettier during development.

@huonw huonw mentioned this pull request Jan 4, 2024
Merged
@thejcannon thejcannon merged commit 3e100e1 into main Jan 4, 2024
1 check passed
@thejcannon thejcannon deleted the jcannon/fixCI branch January 4, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huonw huonw huonw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI isn't validating the files are prettier-ified
2 participants
@thejcannon @huonw