Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate reference docs with all backends enabled #44

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

thejcannon
Copy link
Member

This change fixes #42 by re-running the help-all command with every backend enabled. The list of backends is calculated by using all the keys of .name_to_backend_help_info from a run of help-all.

@thejcannon thejcannon requested review from kaos and huonw January 2, 2024 20:54
@thejcannon thejcannon enabled auto-merge (squash) January 2, 2024 21:01
@thejcannon thejcannon merged commit 7885590 into main Jan 2, 2024
1 check passed
@thejcannon thejcannon deleted the jcannon/all-subsystems branch January 2, 2024 21:25
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

# Run the command twice, since the first run might put extraneous crap on stdout
# First run `help-all` which will contain the list of every backend in the `name_to_backend_help_info` object,
# then run it again with every backend enabled.
# NB: We run the command initially twice, since the first run might put extraneous crap on stdout.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, is this something we can file a Pants bug about, since it's seems... unhelpful?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be a scie-pants issue but haven't had time to dig in

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this covers it: pantsbuild/pants#20315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync_docs.yml missing most backends
3 participants