-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check in help-all.json
for posterity
#43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
Is the list of backends basically a reproduction of https://github.com/pantsbuild/pants/blob/7a1cd54d98a43485027d2ac53099565900659811/build-support/bin/generate_docs.py#L174-L227 ?
@@ -60,6 +60,7 @@ jobs: | |||
- run: | | |||
rm -rf "pantsbuild.org/${{ steps.get-destination-dir.outputs.DESTINATION_DIR }}" | |||
mkdir "pantsbuild.org/${{ steps.get-destination-dir.outputs.DESTINATION_DIR }}" | |||
cp help-all.json "pantsbuild.org/${{ steps.get-destination-dir.outputs.DESTINATION_DIR }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't comment directly on the line, but the pants help-all
invocation used in this script appears to be different to the one in the PR description; is that intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean with regards to backend packages? If so, see #44
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah; cool 👍
Yup! |
Although in some cases backends were missing, so I also plugged some holes |
This changed fixes #29 by:
help-all.json
for every version, under thereference
directoryScript to generate these versions
(Note
/home/josh/work/scie-pants/dist/scie-pants-linux-x86_64
contains a temporary fix for pantsbuild/scie-pants#321)