Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle undefined better in docusaurus.config.js #39

Closed
wants to merge 1 commit into from
Closed

Handle undefined better in docusaurus.config.js #39

wants to merge 1 commit into from

Conversation

thejcannon
Copy link
Member

Fixes #7 by being more methodical about isDev and undefined values.

The crux of the issue was the bad ternary test on line 66.

Tested with npm run build && npm run serve and going to localhost:3000/foo

@thejcannon thejcannon requested a review from huonw January 2, 2024 19:08
@thejcannon thejcannon enabled auto-merge (squash) January 2, 2024 19:09
@thejcannon
Copy link
Member Author

This isn't working as expected. Will open new PR

@thejcannon thejcannon closed this Jan 2, 2024
auto-merge was automatically disabled January 2, 2024 19:46

Pull request was closed

@thejcannon thejcannon deleted the jcannon/404 branch January 2, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huonw huonw Awaiting requested review from huonw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure 404 page is visible for all wrong URLs
1 participant
@thejcannon