Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect mostRecentPreReleaseVersion in a way that actually works #258

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

cburroughs
Copy link
Contributor

Followup to 6136389. The redirect for /stable and /dev worked, but not /prerelease.

Test on fully built site:

$ curl http://localhost:3000/2.22/docs/introduction/welcome-to-pants
<!DOCTYPE html>
<html>
  <head>
    <meta charset="UTF-8">
    <meta http-equiv="refresh" content="0; url=/prerelease/docs/introduction/welcome-to-pants">
    <link rel="canonical" href="/prerelease/docs/introduction/welcome-to-pants" />
  </head>
  <script>
    window.location.href = '/prerelease/docs/introduction/welcome-to-pants' + window.location.search + window.location.hash;
  </script>

Followup to 6136389.  The redirect for /stable and /dev worked, but
not /prerelease.

Test on fully built site:
```
$ curl http://localhost:3000/2.22/docs/introduction/welcome-to-pants
<!DOCTYPE html>
<html>
  <head>
    <meta charset="UTF-8">
    <meta http-equiv="refresh" content="0; url=/prerelease/docs/introduction/welcome-to-pants">
    <link rel="canonical" href="/prerelease/docs/introduction/welcome-to-pants" />
  </head>
  <script>
    window.location.href = '/prerelease/docs/introduction/welcome-to-pants' + window.location.search + window.location.hash;
  </script>
```
@cburroughs cburroughs self-assigned this Sep 5, 2024
@cburroughs cburroughs merged commit 58d59dd into main Sep 5, 2024
1 check passed
@cburroughs cburroughs deleted the csb/friendly-pre-fix branch September 5, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants