Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few tweaks to the README #21

Merged
merged 2 commits into from
Dec 30, 2023
Merged

A few tweaks to the README #21

merged 2 commits into from
Dec 30, 2023

Conversation

thejcannon
Copy link
Member

Fixes #18 as well as a drive-by typo.

@huonw
Copy link
Contributor

huonw commented Dec 30, 2023

There's still a bunch of npm instead of yarns. Is that intentional?

@thejcannon
Copy link
Member Author

Those are the commands I use. I'm no web expert, I suspect that after yarn install the node_modules is in a state where npm can run reasonably. 🤷‍♂️

@thejcannon thejcannon enabled auto-merge (squash) December 30, 2023 20:33
huonw
huonw approved these changes Dec 30, 2023
View reviewed changes
Copy link
Contributor

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for me! Thanks

@thejcannon thejcannon merged commit 113200c into main Dec 30, 2023
1 check passed
@thejcannon thejcannon deleted the jcannon/readme-tweaks branch December 30, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huonw huonw huonw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instructions for running locally appear to be out of date
2 participants
@thejcannon @huonw