Centralise versioning configuration #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huonw
changed the title
benjyw
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to centralise the logic around versions, creating a list of all the details about each version (e.g. full version number, whether it's a pre-release or unmaintained etc.), that downstream processing can reference directly rather than recompute. This, for instance, eliminates the duplicated logic around which versions are maintained.
The goal here is to make changes like #174 (and maybe #159) easier. This PR doesn't/shouldn't change observable behaviour.
This also removes the explicit
disableVersioningflag, since that seems to require changing the contents of theversionsmap. Instead the existing use ofonlyIncludeVersionsseems to do what's intended: make dev builds faster. Annpm startbuild takes about 10s both with the olddisableVersioningsetting, or just relying ononlyIncludeVersions.This includes some cut-and-paste rearrangement too that makes the diff harder to understand. The commits are individually reviewable.