Rip out more parts of the legacy parser #21643
Conversation
| from pants.util.frozendict import LazyFrozenDict | ||
| from pants.util.strutil import first_paragraph, strval | ||
|
|
||
| T = TypeVar("T") | ||
|
|
||
| _ENV_SANITIZER_RE = re.compile(r"[.-]") |
There was a problem hiding this comment.
This file is now the only place using this, so it moved here from parser.py
| # Global options have three env var variants. The last one is the most human-friendly. | ||
| env_var = Parser.get_env_var_names(self._scope, dest)[-1] | ||
| udest = dest.upper() | ||
| if self._scope == GLOBAL_SCOPE: |
There was a problem hiding this comment.
This is (simplified) logic moved from parser.py.
There was a problem hiding this comment.
for my information: we take only the last element, so we can discard the logic that computes the other values
| @@ -107,24 +92,14 @@ def _invert(cls, s: bool | str | None) -> bool | None: | |||
| b = cls.ensure_bool(s) | |||
| return not b | |||
|
|
|||
| @classmethod | |||
| def scope_str(cls, scope: str) -> str: | |||
There was a problem hiding this comment.
This was only used in Parser._scope_str() below, so is now inlined there.
| env_vars = [f"PANTS_{sanitized_env_var_scope}_{udest}"] | ||
| return env_vars | ||
|
|
||
| def _compute_value(self, dest, kwargs, flag_val_strs, passthru_arg_strs, log_warnings): |
There was a problem hiding this comment.
Deleting this is the big win in this PR.
| @@ -1106,9 +1109,16 @@ def get_option_help_info(self, args, kwargs): | |||
| removal_hint = kwargs.get("removal_hint") | |||
| choices = self.compute_choices(kwargs) | |||
|
|
|||
| dest = Parser.parse_dest(*args, **kwargs) | |||
| dest = parse_dest(*args, **kwargs) | |||
| # Global options have three env var variants. The last one is the most human-friendly. | |||
There was a problem hiding this comment.
| # Global options have three env var variants. The last one is the most human-friendly. | |
| # Global options have three env var variants | |
| # (eg. PANTS_GLOBAL_PANTS_WORKDIR, PANTS_PANTS_WORKDIR, PANTS_WORKDIR). | |
| # The last one is the most human-friendly. |
maybe port these from the comment since its being deleted
| # Global options have three env var variants. The last one is the most human-friendly. | ||
| env_var = Parser.get_env_var_names(self._scope, dest)[-1] | ||
| udest = dest.upper() | ||
| if self._scope == GLOBAL_SCOPE: |
There was a problem hiding this comment.
for my information: we take only the last element, so we can discard the logic that computes the other values
Not yet, no. There will be some soon though. |
No description provided.