Make sure FirstPartyHelmDeploymentMapping doesn't get calculated if disabled (Cherry-pick of #21633) #21636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isabled (pantsbuild#21633) Option `[helm-infer].deployment_dependencies` was added in pantsbuild#21282. Unfortunately, I missed one place where `FirstPartyHelmDeploymentMapping` is requested: ```python @rule(desc="Prepare Helm deployment post-renderer", level=LogLevel.DEBUG) async def prepare_post_renderer_for_helm_deployment( request: HelmDeploymentPostRendererRequest, union_membership: UnionMembership, docker_options: DockerOptions, ) -> SetupHelmPostRenderer: mapping = await Get( FirstPartyHelmDeploymentMapping, FirstPartyHelmDeploymentMappingRequest(request.field_set) ) ... ``` Here I move this logic inside the rule, so that all consumers correctly handle the case when `[helm-infer].deployment_dependencies` is set to `false`
tdyas
added
category:bugfix
tdyas
changed the title
|
This PR did not automatically cherry pick to the |
|
cc @grihabor |
grihabor
approved these changes
Nov 12, 2024
|
shall we merge it now? |
I can't because it still needs a maintainer to approve. |
benjyw
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option
[helm-infer].deployment_dependencieswas added in #21282. Unfortunately, I missed one place whereFirstPartyHelmDeploymentMappingis requested:Here I move this logic inside the rule, so that all consumers correctly handle the case when
[helm-infer].deployment_dependenciesis set tofalse