Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation to untyped function causing mypy note #21611

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Nov 4, 2024

Running pants check :: currently gets a note level warning from mypy. This PR fixes it.

src/python/pants/core/util_rules/external_tool_test.py: note: In function "test_export":
src/python/pants/core/util_rules/external_tool_test.py:194:5: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]
src/python/pants/core/util_rules/external_tool_test.py:215:5: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]

This appears to be caused by a minor oversight in a test in #21258 (missing the -> None).

@huonw huonw added the release-notes:not-required PR doesn't require mention in release notes label Nov 4, 2024
@huonw huonw marked this pull request as ready for review November 4, 2024 05:50
@huonw huonw merged commit 89e8819 into main Nov 11, 2024
24 checks passed
@huonw huonw deleted the huonw/export-test-untyped-note branch November 11, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:not-required PR doesn't require mention in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants