Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade semgrep 1.86 -> 1.94 #21595

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Upgrade semgrep 1.86 -> 1.94 #21595

merged 2 commits into from
Nov 1, 2024

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Oct 31, 2024

Just keeping up-to-date, since there's been a few releases since the last upgrade.

@huonw huonw marked this pull request as ready for review October 31, 2024 22:39
@@ -90,6 +90,10 @@ Mypy will now typecheck previously-ignored python sources without a `.py` or `.p

The `pants.backend.url_handlers.s3` backend now correctly passes along query parameters such as `versionId` for `s3://` urls.

#### Semgrep

The default version of [the semgrep tool](https://www.pantsbuild.org/2.24/reference/subsystems/semgrep) has been upgraded from 1.86.0 to 1.94.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The default version of [the semgrep tool](https://www.pantsbuild.org/2.24/reference/subsystems/semgrep) has been upgraded from 1.86.0 to 1.94.0.
The default version of [the semgrep tool](https://www.pantsbuild.org/2.24/reference/subsystems/semgrep) has been upgraded from 1.86.0 to [1.94.0](https://github.com/semgrep/semgrep/releases/tag/v1.94.0).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I'll add it.

Idle thinking: I'm not sure what to do about 1.87-1.93, linking to each one individually seems like overkill/too much work, but they're all relevant to the upgrade. 🤷

@huonw huonw enabled auto-merge (squash) November 1, 2024 20:56
@huonw huonw merged commit 7d55de3 into main Nov 1, 2024
24 checks passed
@huonw huonw deleted the huonw/semgrep-1.94 branch November 1, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants