Terraform: downgrade python-hcl2 from 4.3.2 to 4.3.0 to work around parsing issues #21361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purajit
force-pushed
the
20240827-pin-python-hcl2
branch
from
d9cf089
to
70cef78
Compare
|
I've marked this for cherrypicking back to 2.21.x and 2.22.x to have it come out in patch releases of those branches. I've updated the PR title to be more specific, because it's what will appear in the release notes of those patch releases. |
huonw
changed the title
huonw
changed the title
huonw
changed the title
WorkerPants
pushed a commit
that referenced
this pull request
Aug 29, 2024
…arsing issues (#21361) `python-hcl2` 4.3.1+ has some serious issues with parsing certain kinds of expressions, like multi-line ternaries. The issues opened can be seen [here](https://github.com/amplify-education/python-hcl2/issues?q=is%3Aissue+is%3Aopen+%22unexpected+token%22). It looks like 4.3.5 has fixed a bunch of the issues, but I'm still seeing some errors on our repo, and I think it's better to keep to 4.3.0 until the authors of the issues close them and we're sure there are no regressions. Also, 4.3.0 is still compatible with py3.12, so it doesn't undo the efforts of #20365. Generated with `pants run build-support/bin/generate_builtin_lockfiles.py -- terraform-hcl2-parser`.
WorkerPants
pushed a commit
that referenced
this pull request
Aug 29, 2024
…arsing issues (#21361) `python-hcl2` 4.3.1+ has some serious issues with parsing certain kinds of expressions, like multi-line ternaries. The issues opened can be seen [here](https://github.com/amplify-education/python-hcl2/issues?q=is%3Aissue+is%3Aopen+%22unexpected+token%22). It looks like 4.3.5 has fixed a bunch of the issues, but I'm still seeing some errors on our repo, and I think it's better to keep to 4.3.0 until the authors of the issues close them and we're sure there are no regressions. Also, 4.3.0 is still compatible with py3.12, so it doesn't undo the efforts of #20365. Generated with `pants run build-support/bin/generate_builtin_lockfiles.py -- terraform-hcl2-parser`.
huonw
pushed a commit
that referenced
this pull request
Aug 29, 2024
…arsing issues (Cherry-pick of #21361) (#21364) `python-hcl2` 4.3.1+ has some serious issues with parsing certain kinds of expressions, like multi-line ternaries. The issues opened can be seen [here](https://github.com/amplify-education/python-hcl2/issues?q=is%3Aissue+is%3Aopen+%22unexpected+token%22). It looks like 4.3.5 has fixed a bunch of the issues, but I'm still seeing some errors on our repo, and I think it's better to keep to 4.3.0 until the authors of the issues close them and we're sure there are no regressions. Also, 4.3.0 is still compatible with py3.12, so it doesn't undo the efforts of #20365. Generated with `pants run build-support/bin/generate_builtin_lockfiles.py -- terraform-hcl2-parser`. Co-authored-by: purajit <[email protected]>
huonw
pushed a commit
that referenced
this pull request
Sep 9, 2024
…arsing issues (Cherry-pick of #21361) (#21365) `python-hcl2` 4.3.1+ has some serious issues with parsing certain kinds of expressions, like multi-line ternaries. The issues opened can be seen [here](https://github.com/amplify-education/python-hcl2/issues?q=is%3Aissue+is%3Aopen+%22unexpected+token%22). It looks like 4.3.5 has fixed a bunch of the issues, but I'm still seeing some errors on our repo, and I think it's better to keep to 4.3.0 until the authors of the issues close them and we're sure there are no regressions. Also, 4.3.0 is still compatible with py3.12, so it doesn't undo the efforts of #20365. Generated with `pants run build-support/bin/generate_builtin_lockfiles.py -- terraform-hcl2-parser`. Co-authored-by: purajit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python-hcl24.3.1+ has some serious issues with parsing certain kinds of expressions, like multi-lineternaries. The issues opened can be seen here.
It looks like 4.3.5 has fixed a bunch of the issues, but I'm still seeing some errors on our repo, and I think
it's better to keep to 4.3.0 until the authors of the issues close them and we're sure there are no regressions.
Also, 4.3.0 is still compatible with py3.12, so it doesn't undo the efforts of #20365.
Generated with
pants run build-support/bin/generate_builtin_lockfiles.py -- terraform-hcl2-parser.