Scala: Detect consumed symbols in self-type annotations #20960
Conversation
alonsodomin
added
backend: JVM
|
Nice fix! I don't think this warrants cherry-picking though, and certainly not back to 2.19.x. It's on the border between a bugfix and a feature, and there has always been a workaround via a manual dep, so I think it's best to treat this as a new feature and keep it in 2.22.x and not expect a bunch more releases, especially since we want to stabilize 2.21.0 now. WDYT? |
|
In a way it feels like a bug as the parser is blind to a Scala language feature and requires for a user workaround. But it's true that it also could be categorised as a new feature: Scala dependency inference now supports self-types. Either way, I don't need it backported to 2.19 and since it's workaround-able I'm happy having it coming in 2.22. I added the milestone and cherry picking after the suggestion in the ticket, but was also waiting for someone else to chime in. |
alonsodomin
added
category:new feature
and removed
needs-cherrypick
category:bugfix
…ckage (#21053) Fixes #20302 Types in match patterns are not detected as consumed symbols. So dependency inference fails to detect symbols in the same package in a different file unless imported or added to dependencies manually. This fixes inference for cases like: ```scala // A.scala package pkg class AClass // B.scala package pkg def myFn = { case v: AClass => } ``` Similar to a another recent fix [here](#20960)
Fixes #20959.