Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always match source globs using the any conjunction. #20958

Merged
merged 2 commits into from
May 28, 2024
Merged

Always match source globs using the any conjunction. #20958

merged 2 commits into from
May 28, 2024

Conversation

kaos
Copy link
Member

@kaos kaos commented May 27, 2024

Relax the glob matching conjunction to only err if none match rather than requiring all to match.

See #20947 for background and linked alternative abandoned solution.

Closes #20947.

@kaos kaos added the category:bugfix Bug fixes for released features label May 27, 2024
@kaos kaos requested a review from benjyw May 27, 2024 08:57
Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like an improvement.

Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Frankly I'd prefer not to error even if all globs are empty, but that's for another day... :)

@kaos kaos merged commit 81962e6 into main May 28, 2024
25 checks passed
@kaos kaos deleted the kaos/20947 branch May 28, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Values from __defaults__ are not treated the same as builtin field defaults.
3 participants