Don't filter the env passed to OptionsBootstrapper. #20956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The native parser needs access to all env vars for interpolation, so we can't filter down to just PANTS_*. Once we're rid of the legacy parser and can simplify options bootstrapping, we can revisit exactly how to do this, but for now we're OK with OptionsBootstrapper holding more data than it strictly needs.
|
Note that the underlying issue is that native parser uses the env from OptionsBootstrapper for interpolation, whereas the legacy parser parses Config before OptionsBootstrapper is even created. |
|
Fixes #20952 |
Hint: if you edit that comment into the PR description, GH will auto-close the issue when this gets merged. |
|
On second thoughts, instead of skipping the test I'll make it test the new behavior, so we know if that gets reverted (and to force us to fix the test if/when we do revert it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The native parser needs access to all env vars for interpolation,
so we can't filter down to just PANTS_*.
Once we're rid of the legacy parser and can simplify options bootstrapping,
we can revisit exactly how to do this, but for now we're OK with
OptionsBootstrapper holding more data than it strictly needs.