Introduce support for per field instance default values. #20949
Conversation
| } | ||
|
|
||
| fn cls_alias(cls: &PyAny) -> PyResult<&str> { | ||
| // TODO: All of these methods should use interned attr names. |
There was a problem hiding this comment.
I fixed ^^ while I was at it..
| // context to call it. | ||
| let slf = self_.borrow_mut().into_ptr(); | ||
| let attr = name.into_py(py).into_ptr(); | ||
| let res = ffi::PyObject_GenericGetAttr(slf, attr); |
There was a problem hiding this comment.
This call (along with how to handle the returned value) was taken from https://github.com/PyO3/pyo3/blob/dc4f114d6772337d8b1568c6dbb0bf35deaa84dd/src/impl_/pyclass.rs#L212
|
I've no idea what I'm doing here.. it was a simple enough thing in Python but I've been pulling my hair for hours to get this to work in Rust using pyo3.. (due to me lacking Rust proficiency..) |
| unsafe { | ||
| // The ffi::PyObject_GenericGetAttr() call is unsafe, so we need to be in an unsafe | ||
| // context to call it. | ||
| let slf = self_.borrow_mut().into_ptr(); | ||
| let attr = name.into_py(py).into_ptr(); | ||
| let res = ffi::PyObject_GenericGetAttr(slf, attr); | ||
| if res.is_null() { | ||
| Err(PyErr::fetch(py)) | ||
| } else { | ||
| Ok(res) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
there ought to be a better way to do this...
https://stackoverflow.com/questions/78522334/how-do-i-call-the-equiv-of-object-getattribute-self-name-using-pyo3
Hoping to be able to leverage `Bound` for #20949
|
As I commented on the issue, this (and the other change) seems like a lot of extra complexity, just to conserve a "feature" that I think is pretty silly to begin with... Maybe instead we do the "alexandrian solution" of just getting rid of that silly error? :) |
|
As discussed on #20947 we opt to change the behavior for source globs instead of having a conditional on the value being default or not, so we no longer need to be able to track overriding defaults per field instance. |
Part 1 of 2 to address #20947 (Part 2: #20950)
This adds support for overriding the class var field default value per field instance.