Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower log message level for nailgun to reduce verbosity #20946

Merged
merged 11 commits into from
May 27, 2024
4 changes: 4 additions & 0 deletions docs/notes/2.22.x.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ deploy jars, in addition to those specified on a per-jar basis in the `deploy_ja
This option's default value excludes signature files from constituent jars, which are known to cause the deploy jar
to fail to execute (since naturally it doesn't match those signatures).

Also reduced verbosity of log messages for the internal Nailgun server instances used for running or compiling code
replacing it by a single message informing about the size of the Nailgun pool. Previous log messages are still
emitted at debug log level.

##### Scala

Setting the `orphan_files_behaviour = "ignore"` option for [`pants.backend.experimental.scala.lint.scalafix`](https://www.pantsbuild.org/2.22/reference/subsystems/scalafix#orphan_files_behavior) or [`pants.backend.experimental.scala.lint.scalafmt`](https://www.pantsbuild.org/2.22/reference/subsystems/scalafmt#orphan_files_behavior) backend is now properly silent. It previously showed spurious warnings.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ pub struct NailgunPool {

impl NailgunPool {
pub fn new(workdir_base: PathBuf, size: usize, store: Store, executor: Executor) -> Self {
info!("Initializing Nailgun pool for {} processes...", size);
NailgunPool {
workdir_base,
size,
Expand Down Expand Up @@ -285,9 +286,7 @@ fn spawn_and_read_port(
workdir: PathBuf,
) -> Result<(std::process::Child, Port), String> {
let cmd = process.argv[0].clone();
// TODO: This is an expensive operation, and thus we info! it.
// If it becomes annoying, we can downgrade the logging to just debug!
info!(
debug!(
"Starting new nailgun server with cmd: {:?}, args {:?}, in cwd {}",
cmd,
&process.argv[1..],
Expand Down
Loading