Replaced pre-commit githook with pre-push #20784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sureshjoshi
commented
Apr 13, 2024
| @@ -61,32 +61,30 @@ To free up space, run `rm -rf src/rust/engine/target`. | |||
| Warning: this will cause Rust to recompile everything. | |||
| ::: | |||
|
|
|||
| ## Step 3: (Optional) Set up a Git hook | |||
| ## Step 3: Set up a pre-push Git Hook | |||
There was a problem hiding this comment.
Removing "Optional"
Seems weird to write that in the development docs. For the people who develop often, they're used to the workflow and can do as they please anyways.
For those who are new to committing to Pants, this feels like a simple thing that would be nice to save some CI loops.
sureshjoshi
commented
Apr 13, 2024
|
|
||
| To install this, run: | ||
|
|
||
| ```bash | ||
| $ build-support/bin/setup.sh | ||
| ``` | ||
|
|
||
| If you commit frequently as part of your workflow you may find it annoying to have these run every time, so installing this hook is not required. |
There was a problem hiding this comment.
Removing "Optional".
The frequency of run is now substantially lower, since it's on push instead of commit.
kaos
approved these changes
Apr 15, 2024
|
@kaos Just a heads up that I added a function which will look for broken symlinks in the githooks, and ask the user if they want to delete it. Just a bit of house keeping. |
kaos
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that we wrote:
explains why I'm making this change :)
Closes #20541