Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a more friendly pointer on unconfigured constraint file #20781

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

cburroughs
Copy link
Contributor

Or more formally, a mismatch between the lockfile metadata saying there should be constraints when none is configured. Previously this showed up as a bare:

Engine traceback:
  in `package` goal

AssertionError:

Or more formally, a mismatch between the lockfile metadata saying
there should be constraints when none is configured.  Previously this
showed up as a bare:

```
Engine traceback:
  in `package` goal

AssertionError:
```
@cburroughs cburroughs self-assigned this Apr 12, 2024
@cburroughs cburroughs added category:bugfix Bug fixes for released features backend: Python Python backend-related issues labels Apr 12, 2024
Copy link
Contributor

@lilatomic lilatomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always a plus for better error messages! Do we want to include the path the lockfile metadata expects?

@cburroughs
Copy link
Contributor Author

Do we want to include the path the lockfile metadata expects?

The path isn't preserved in the metadata, just the contents, so this isn't something known.

@huonw huonw merged commit d2a9a46 into pantsbuild:main Apr 17, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: Python Python backend-related issues category:bugfix Bug fixes for released features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants