Get rid of a TestCase class. #20656
Merged
Get rid of a TestCase class. #20656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the giant diff - I do not recommend reviewing line-by-line but taking in the principle of the thing. Again, the change was done via find-and-replace. |
huonw
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Cool!
The ignore-whitespace diff made this easier to review: https://github.com/pantsbuild/pants/pull/20656/files?diff=split&w=1
Good tip! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns its members into new-style standalone test_* functions
(and a couple of helpers).
The diff is large, but the change is purely mechanical: dedent the
functions and remove all references to self. The proof is that all
77 tests in this file pass after this change (I have verified
that no tests are missed by the pytest collector).
This is in preparation for integrating the rust options parser, which
may require adding test fixtures, which is not a feature available
to old-style class based tests.