Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Pex to 2.2.1 (Cherry-pick of #20587, etc.) #20653

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Mar 7, 2024

Cherry pick of #20587 , which includes:

The upgrade past https://github.com/pex-tool/pex/releases/tag/v2.1.154 is what is acutely driving this cherry-pick, as it resolves the over-long shebang issue (#20651) where the Pants bin/pants script can have a #!... line that's too long.

Closes #20651

Changelogs:
 * https://github.com/pex-tool/pex/releases/tag/v2.1.164
 * https://github.com/pex-tool/pex/releases/tag/v2.2.0
 * https://github.com/pex-tool/pex/releases/tag/v2.2.1

(New home, new docs, but no direct Pants related changes.)

```
Lockfile diff: 3rdparty/python/user_reqs.lock [python-default]

==                    Upgraded dependencies                     ==

  cryptography                   42.0.2       -->   42.0.3
  pex                            2.1.163      -->   2.2.1
  urllib3                        2.2.0        -->   2.2.1
```
@huonw huonw added this to the 2.19.x milestone Mar 7, 2024
@huonw huonw added the category:internal CI, fixes for not-yet-released features, etc. label Mar 7, 2024
@huonw huonw requested a review from cburroughs March 7, 2024 21:29
@huonw huonw changed the title upgrade Pex to 2.2.1 (Cherry-pick of #20587) upgrade Pex to 2.2.1 (Cherry-pick of #20587, etc.) Mar 7, 2024
default_version = "v2.1.148"
default_url_template = "https://github.com/pantsbuild/pex/releases/download/{version}/pex"
default_version = "v2.2.1"
default_url_template = "https://github.com/pex-tool/pex/releases/download/{version}/pex"
version_constraints = ">=2.1.135,<3.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB. this leaves this at the same constraint it was in 2.19, which is different to what it was in #20587. In particular, #20481 and #20598 aren't cherry-picked.

@huonw
Copy link
Contributor Author

huonw commented Mar 7, 2024

Apparently the fix for the shebang issue in #20651 is in 2.1.154, so we could reduce the "blast radius" here by doing a more minimal update to just that version. I'm not sure it's necessary!

@huonw huonw merged commit 3299a32 into 2.19.x Mar 7, 2024
24 checks passed
@huonw huonw deleted the cherry-pick-20587-to-2.19.x branch March 7, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants