fix type issues.

pantsbuild · May 23, 2024 · d8af6ee · d8af6ee
1 parent 565748c
commit d8af6ee
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/python/pants/engine/internals/native_engine.pyi b/src/python/pants/engine/internals/native_engine.pyi
@@ -288,6 +288,7 @@ class FieldDefaultValue:
 
     value: ImmutableValue
 
+    def __init__(self, value: ImmutableValue) -> None: ...
     def __repr__(self) -> str: ...
     def __str__(self) -> str: ...
 

diff --git a/src/python/pants/engine/target_test.py b/src/python/pants/engine/target_test.py
@@ -474,14 +474,13 @@ def test_target_residence_dir() -> None:
 
 def test_field_dynamic_default() -> None:
     class SomeField(Field):
-        alias: str = "some"
-        default: str = "some-default"
+        alias: ClassVar[str] = "some"
+        default: ClassVar[str] = "some-default"
 
         @classmethod
         def compute_value(cls, raw_value: Optional[str], address: Address) -> str:
             value_or_default = super().compute_value(raw_value, address)
-            print(f"compute {raw_value=}, {value_or_default=}")
-            assert not isinstance(value_or_default, FieldDefaultValue)
+            assert isinstance(value_or_default, str)
             return value_or_default
 
     def check_field(fld: SomeField, value: str, default: str) -> None: