-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THREAT-397 Reformat deep_get(event to event.deep_get( #1374
THREAT-397 Reformat deep_get(event to event.deep_get( #1374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was reformatted by black
Some of the helper unit tests are failing because ImmutableDict doesn't have a deep_get field. I'm not sure of this is a problem with the test or the new changes. A couple of the failing tests have been due to us defining events as ImmutableDicts instead of PantherEvent, but I haven't worked through all of them. Please don't merge yet. :) |
The issue with the test is that the test setup functions were using I also replaced some |
@ben-githubs Thanks for your help! |
Very nice! Does it make sense to refactor data_models as well? |
I don't think we can. It appears that while using data models |
Changes
deep_get(event
toevent.deep_get(
deep_walk(event
toevent.deep_walk(