Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce mypy, ruff, and pre-commit #1215

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Introduce mypy, ruff, and pre-commit #1215

wants to merge 12 commits into from

Commits on Apr 20, 2024

  1. Apply mypy to panther_base_helpers.py

    @corrylc
    corrylc committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    f0d9949 View commit details
    Browse the repository at this point in the history

  2. Apply ruff to panther_base_helpers.py

    @corrylc
    corrylc committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    1689a5e View commit details
    Browse the repository at this point in the history

  3. Apply ruff-format to panther_base_helpers.py

    @corrylc
    corrylc committed Apr 20, 2024
    Configuration menu
    Copy the full SHA
    0c29195 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Simplify pre-commit file selection

    @corrylc
    corrylc committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    bf19d99 View commit details
    Browse the repository at this point in the history

  2. Install pre-commit as a github action

    @corrylc
    corrylc committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    d499d62 View commit details
    Browse the repository at this point in the history

  3. Remove blank lines from imports 

    While isort and ruff mostly agree, ruff won't remove blank lines.
    @corrylc
    corrylc committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    3136aed View commit details
    Browse the repository at this point in the history

  4. Address formatting issues

    @corrylc
    corrylc committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    5bb01a5 View commit details
    Browse the repository at this point in the history

  5. Address prettier feedback

    @corrylc
    corrylc committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    3ae1ff3 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Expand typing to greynoise/lookuptable helpers

    @corrylc
    corrylc committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e29ff80 View commit details
    Browse the repository at this point in the history

  2. Expand typing to config/event_type helpers

    @corrylc
    corrylc committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    3d7c342 View commit details
    Browse the repository at this point in the history

  3. Run prettier

    @corrylc
    corrylc committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a8ee50e View commit details
    Browse the repository at this point in the history

  4. Re-capture very odd default behavior of deep_get

    @corrylc
    corrylc committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    6d57d6e View commit details
    Browse the repository at this point in the history