Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing rules that were failing validation #1041

Merged
merged 5 commits into from
Dec 14, 2023
Merged

Fixing rules that were failing validation #1041

merged 5 commits into from
Dec 14, 2023

Conversation

kostaspap
Copy link
Contributor

@kostaspap kostaspap commented Dec 14, 2023

Background

Fixing issues with rules that were failing validation

Changes

  • Deleting netskope_admin_user_change.yml detection that had invalid syntax and removing it from Netscope pack.
  • Removed Tailscale.Network mappings in LUTS

Testing

  • Validated against Panther test instance

le4ker
le4ker previously approved these changes Dec 14, 2023
@kostaspap kostaspap marked this pull request as ready for review December 14, 2023 13:02
@kostaspap kostaspap requested review from a team December 14, 2023 13:02
@kostaspap kostaspap self-assigned this Dec 14, 2023
egibs
egibs previously approved these changes Dec 14, 2023
le4ker
le4ker previously approved these changes Dec 14, 2023
@kostaspap kostaspap dismissed stale reviews from le4ker and egibs via 2f4eeca December 14, 2023 13:06
@kostaspap kostaspap enabled auto-merge (squash) December 14, 2023 13:10
@kostaspap kostaspap merged commit aea6bb2 into main Dec 14, 2023
3 checks passed
@kostaspap kostaspap deleted the kostas-fix-rules branch December 14, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants