Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add panther_config to packs using panther_base_helpers #1040

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Add panther_config to packs using panther_base_helpers #1040

merged 1 commit into from
Dec 13, 2023

Conversation

egibs
Copy link
Contributor

@egibs egibs commented Dec 13, 2023

Background

Packs that import panther_base_helpers also need to import panther_config now that it imports panther_config.

Changes

  • Adds panther_config to all Packs that import panther_base_helpers

Testing

  • make test

@egibs egibs requested review from a team December 13, 2023 19:57
@egibs egibs merged commit 12019bc into main Dec 13, 2023
3 checks passed
@egibs egibs deleted the egibs-add-panther-config-to-all-packs branch December 13, 2023 20:00
@egibs egibs mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielkr256 arielkr256 arielkr256 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egibs @arielkr256