Skip to content

Commit

Permalink
Remove Node/NPM/Prettier (#1241)
Browse files Browse the repository at this point in the history
* Remove Node/NPM/Prettier

Signed-off-by: egibs <[email protected]>

* Update README; add removal notes

Signed-off-by: egibs <[email protected]>

---------

Signed-off-by: egibs <[email protected]>
  • Loading branch information
egibs authored May 22, 2024
1 parent 63db6ce commit 442849c
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 65 deletions.
Binary file added .img/panther-logo-github-highres-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added .img/panther-logo-github-highres-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed .img/panther-logo-github-highres.png
Binary file not shown.
8 changes: 0 additions & 8 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ RUN apk update \
git \
libffi-dev \
ncurses-dev \
nodejs \
npm \
openssl-dev \
readline-dev \
sqlite-dev \
Expand Down Expand Up @@ -49,12 +47,6 @@ COPY Pipfile.lock .
RUN pipenv uninstall --all
RUN pipenv sync --dev

COPY package.json .
COPY package-lock.json .
RUN npm install

ENV PATH="/home/panther-analysis/node_modules/.bin:$PATH"

# Remove pipfile so it doesn't interfere with local files after install
RUN rm Pipfile
RUN rm Pipfile.lock
4 changes: 0 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ lint-pylint:
lint-fmt:
@echo Checking python file formatting with the black code style checker
pipenv run black --line-length=100 --check $(dirs)
npx prettier . --check

venv:
pipenv sync --dev
Expand All @@ -53,12 +52,9 @@ pat-update:
fmt:
pipenv run isort --profile=black $(dirs)
pipenv run black --line-length=100 $(dirs)
npx prettier . --write --list-different

install:
pipenv sync --dev
# install prettier for formatting YAML and Markdown files
npm install

test: global-helpers-unit-test
pipenv run panther_analysis_tool test $(TEST_ARGS)
Expand Down
14 changes: 13 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
<p align="center">
<a href="https://panther.com"><img src=".img/panther-logo-github-highres.png" width=40% alt="Panther Logo"/></a>
<a href="https://panther.com"><picture>
<source media="(prefers-color-scheme: dark)" srcset=".img/panther-logo-github-highres-light.png" width=75%>
<source media="(prefers-color-scheme: light)" srcset=".img/panther-logo-github-highres-dark.png" width=75%>
<img alt="Displays the dark Panther logo in light mode an the light Panther logo in dark mode.">
</picture></a>
</p>

<h3 align="center">Built-in Panther Detections</h3>
Expand Down Expand Up @@ -255,6 +259,14 @@ git pull panther-upstream main
git push
```
# Remove Deprecated Formatters
Previously, Node, NPM and Prettier were used for formatting Markdown and YAML files; these are no longer in use.
Depending on how Node is managed, it will need to be uninstalled or removed if it is no longer needed elsewhere. Refer to your system/package manager's documentation for instructions on removing Node.
Otherwise, running `npm unintall prettier` will remove Prettier.
# License
This repository is licensed under [Apache License, Version 2.0](https://github.com/panther-labs/panther-analysis/blob/main/LICENSE.txt).
43 changes: 0 additions & 43 deletions package-lock.json

This file was deleted.

9 changes: 0 additions & 9 deletions package.json

This file was deleted.

0 comments on commit 442849c

Please sign in to comment.