Safely handle a potential KeyError inside zoom operation passcode dis…

…abled (#749) * Safely handle zoom non-update events
panther-labs · May 11, 2023 · 000807e · 000807e
1 parent 2ffc054
commit 000807e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/rules/zoom_operation_rules/zoom_operation_passcode_disabled.py b/rules/zoom_operation_rules/zoom_operation_passcode_disabled.py
@@ -6,7 +6,9 @@ def rule(event):
         return False
 
     context = get_context(event)
-    return "Passcode" in context["Change"] and context["DisabledSetting"]
+    changed = "Passcode" in context.get("Change", "")
+    disabled = context.get("DisabledSetting", False)
+    return changed and disabled
 
 
 def title(event):

diff --git a/rules/zoom_operation_rules/zoom_operation_passcode_disabled.yml b/rules/zoom_operation_rules/zoom_operation_passcode_disabled.yml
@@ -44,3 +44,15 @@ Tests:
         "operation_detail": "Edit Group Springfield  - Personal Meeting ID (PMI) Passcode: from Off to On",
         "p_log_type": "Zoom.Operation",
         }
+  -
+    Name: Add User Group
+    ExpectedResult: false
+    Log:
+      {
+        "time": "2021-11-17 00:37:24Z",
+        "operator": "[email protected]",
+        "category_type": "User Group",
+        "action": "Add",
+        "operation_detail": "Add Group Engineers",
+        "p_log_type": "Zoom.Operation",
+        }