Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic info to WordPress' health check screen #353

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dsXLII
Copy link

@dsXLII dsXLII commented May 6, 2022

Since there's a wp-cli command to display some basic Redis info, why not make it available in WordPress' own health check interface?

This is the "I banged it out in like half an hour" version, feel free to completely rewrite it, put this code somewhere else. Think of it as a starting point more than anything else.

@mwt
Copy link

mwt commented Jun 19, 2022

Thanks! I think this is an important feature even for Pantheon users.

@timnolte
Copy link
Contributor

This code apparently has some problems when connecting to a Redis 6 instance. I'm doing some digging into it as this would be helpful to have somewhere in the Dashboard.

@timnolte
Copy link
Contributor

Actually, I was having issues locally with the Redis 6 Docker image and I determined that I needed to set the password in the redis.conf and have it matching in the plugin setup. Then it worked.

@jazzsequence jazzsequence marked this pull request as ready for review April 5, 2023 20:35
@jazzsequence jazzsequence requested a review from a team as a code owner April 5, 2023 20:35
@jazzsequence jazzsequence requested a review from a team April 5, 2023 20:37
@jazzsequence jazzsequence changed the base branch from master to develop April 5, 2023 20:38
@jazzsequence
Copy link
Contributor

jazzsequence commented Apr 5, 2023

Resurrecting this. Tracking internally as CMSP-344. Tentatively looks good but since Behat tests are failing, I'd like to pull it down and test it before we merge.

@jspellman814 jspellman814 deleted the branch pantheon-systems:main May 8, 2023 23:40
@jspellman814 jspellman814 reopened this May 8, 2023
@pwtyler pwtyler force-pushed the develop branch 2 times, most recently from 7be9fc3 to 2b5e0c5 Compare May 11, 2023 21:51
@timnolte
Copy link
Contributor

timnolte commented Jun 5, 2023

Just noting that I created a MU Plugin for our agency to use on our sites to provide site health for Redis when using this plugin. https://gist.github.com/timnolte/d295f24457698f65f00d301074494394

@jazzsequence
Copy link
Contributor

Thanks for sharing the gist @timnolte!

@timnolte
Copy link
Contributor

It would be nice if the wp_redis_get_info() function also included the following in it's output.

		'redis_version'     => $info['redis_version'],
		'redis_mode'        => $info['redis_mode'],
		'maxclients'        => $info['maxclients'],
		'connected_clients' => $info['connected_clients'],

@timnolte
Copy link
Contributor

Just noting that I created a MU Plugin for our agency to use on our sites to provide site health for Redis when using this plugin. https://gist.github.com/timnolte/d295f24457698f65f00d301074494394

I've updated this Gist to leverage some better error handling as well as incorporate changes in a patch to 1.4.2 I made here(https://gist.github.com/timnolte/267e2a502f05156c0fe2a0d7028c2854) that includes the redis_version, redis_mode, maxclients, and connected_clients attributes.

@pwtyler pwtyler changed the base branch from develop to main July 13, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants